Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta,doc: ping community about new release #24064

Closed
wants to merge 1 commit into from
Closed

meta,doc: ping community about new release #24064

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Nov 3, 2018

Ping the IRC ops and the other [Partner Communities] liaisons.

Refs: http://logs.libuv.org/node-build/2018-11-03#16:44:59.388

/CC @nodejs/releasers @ljharb @dshaw

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1474/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 3, 2018
@refack refack added the meta Issues and PRs related to the general management of the project. label Nov 3, 2018
ljharb
ljharb approved these changes Nov 3, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

joyeecheung
joyeecheung reviewed Nov 3, 2018
View reviewed changes
doc/releases.md
@@ -568,6 +568,8 @@ To ensure communication goes out with the timing of the blog post, please allow
will be shared with the community in the email to coordinate these
announcements.

Ping the IRC ops and the other [Partner Communities] liaisons.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any handles? Also, not sure which IRC channel this would be..#node-build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably #node-dev, as for handles, if they are not online they won't see the notification, so I'd say mention those who are online, e.g.:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even just a message in #node-build and/or #node-dev would be immensely helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ping the IRC ops and the other [Partner Communities] liaisons.
Mention the new release in [freenode#node-build], this should sync with our other [Partner Communities] and inform our liaisons.
[freenode#node-build]: https://www.irccloud.com/irc/freenode/channel/node-build

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like something we should automate rather than do manually

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like 90% of the things in this guide that are still manual 😅

@targos
Copy link
Member

targos commented Nov 3, 2018

I am not in Node Slackers. How do I know who their liaisons are / how to contact them?

@ljharb
Copy link
Member

ljharb commented Nov 3, 2018

@targos it me, if you ping in irc that’s more than sufficient :-)

@refack
Copy link
Contributor Author

refack commented Nov 3, 2018 •
edited
Loading

I am not in Node Slackers. How do I know who their liaisons are / how to contact them?

I linked to https://github.com/nodejs/community-committee/blob/master/PARTNER_COMMUNITIES.md which ref @ljharb as the liaison.
Also we have a two way sync between freenode#node-build to nodeslackers#node-build, so I think a ping in freenode#node-build will cover everything for now

@refack
Copy link
Contributor Author

refack commented Nov 3, 2018

I linked to https://github.com/nodejs/community-committee/blob/master/PARTNER_COMMUNITIES.md which ref @ljharb as the liaison.

Sorry, nodejs/community-committee#410 needs to land first.

@refack refack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 3, 2018
@Trott
Copy link
Member

Trott commented Nov 6, 2018

Landed in 17e4213

@Trott Trott closed this Nov 6, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 6, 2018
@refack @Trott
meta,doc: ping community about new release
17e4213 
PR-URL: nodejs#24064
Refs: http://logs.libuv.org/node-build/2018-11-03#16:44:59.388
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@rvagg
Copy link
Member

rvagg commented Nov 6, 2018

I feel like we need a moratorium on adding additional steps to the release procedure, it's getting out of hand. Add on the extra items for security releases and it's a massive burden. A focus on tooling to improve things might be good.

targos pushed a commit that referenced this pull request Nov 6, 2018
@refack @targos
meta,doc: ping community about new release
10156c6 
PR-URL: #24064
Refs: http://logs.libuv.org/node-build/2018-11-03#16:44:59.388
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@refack refack deleted the release-ping-liaisons branch November 6, 2018 23:17
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Nov 29, 2018
@refack @codebytere
meta,doc: ping community about new release
b2cdf7f 
PR-URL: #24064
Refs: http://logs.libuv.org/node-build/2018-11-03#16:44:59.388
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@refack @MylesBorins
meta,doc: ping community about new release
a93a1df 
PR-URL: #24064
Refs: http://logs.libuv.org/node-build/2018-11-03#16:44:59.388
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@refack @MylesBorins
meta,doc: ping community about new release
a116e32 
PR-URL: #24064
Refs: http://logs.libuv.org/node-build/2018-11-03#16:44:59.388
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@MylesBorins MylesBorins MylesBorins left review comments

@targos targos targos approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@refack @nodejs-github-bot @targos @ljharb @Trott @rvagg @MylesBorins @joyeecheung @codebytere