Commits on Nov 6, 2018

1. tracing: fix static destruction order issue …

   Sometimes, the `parallel/test-tracing-no-crash` would not work as
   expected, at least on Windows, because there is a static destruction
   race between tearing down the `NodeTraceWriter` instance and the
   per-process options struct. If the per-process options were destroyed
   before the `NodeTraceWriter`, the reference to the tracing filename
   would be gone before opening the file was attempted.
   
   This can be solved by creating a copy of the string when creating the
   `NodeTraceWriter` instance rather than taking a reference.
   
   Fixes: nodejs#22523

   

   addaleax committed Nov 6, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 14476ff
   • Browse repository at this point

   Copy the full SHA

   14476ff View commit details

   Browse the repository at this point in the history