build: move headers out of c++ src section #24124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
richardlau
approved these changes
Nov 6, 2018
refack
approved these changes
Nov 7, 2018
mmarchini
approved these changes
Nov 7, 2018
This commit moves a few header files that are listed among the C++ source files for consistency.
|
Landed in 9e82fd2. |
danbev
added a commit
that referenced
this pull request
Nov 9, 2018
This commit moves a few header files that are listed among the C++ source files for consistency. PR-URL: #24124 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
This commit moves a few header files that are listed among the C++ source files for consistency. PR-URL: #24124 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
This commit moves a few header files that are listed among the C++ source files for consistency. PR-URL: nodejs#24124 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
This was referenced Nov 15, 2018
|
@danbev can this be backported to 10.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves a few header files that are listed among the C++
source files for consistency.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes