Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: partially revert 'increase V8 deprecation levels' #24195

Closed
wants to merge 1 commit into from

Conversation

psmarshall
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

The V8 CI on v10x-staging won't build because deprecation warnings are raised to errors at compile time. This is a partial revert of #23159 so that the build can run again.

@nodejs-github-bot nodejs-github-bot added v10.x v8 engine Issues and PRs related to the V8 dependency. labels Nov 6, 2018
@psmarshall
Copy link
Contributor Author

@refack
Copy link
Contributor

refack commented Nov 7, 2018

Note to self: make a semver-patch backport of #23426

@psmarshall
Copy link
Contributor Author

Redoing the linter because it failed: https://ci.nodejs.org/job/node-linter/1510/

@refack
Copy link
Contributor

refack commented Nov 7, 2018

Redoing the linter because it failed: ci.nodejs.org/job/node-linter/1510

It has a rebasing checksum issue. Not relevant for linting.
This run should work: https://ci.nodejs.org/job/node-linter/1511/ ✔️

@psmarshall psmarshall added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 7, 2018
@psmarshall
Copy link
Contributor Author

Thanks @refack. This is ready to land - @MylesBorins could you please land? Thanks 😀

@MylesBorins
Copy link
Contributor

Landed in 2290c31

MylesBorins pushed a commit that referenced this pull request Nov 7, 2018
PR-URL: #24195
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins MylesBorins closed this Nov 7, 2018
@codebytere codebytere mentioned this pull request Nov 27, 2018
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #24195
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
PR-URL: #24195
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants