Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add process no deprecation #24196

Closed
wants to merge 3 commits into from
Closed

test: add process no deprecation #24196

wants to merge 3 commits into from

Conversation

razvanbh
Copy link
Contributor

@razvanbh razvanbh commented Nov 6, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@addaleax addaleax added process Issues and PRs related to the process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Nov 6, 2018
richardlau
richardlau reviewed Nov 6, 2018
View reviewed changes
test/parallel/test-child-process-no-deprecation.js Outdated
const spawn = require('child_process').spawn;

// spawn self as child
const child = spawn(process.argv[0], [process.argv[1], 'child']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const child = spawn(process.argv[0], [process.argv[1], 'child']);
const child = spawn(process.execPath, [process.argv[1], 'child']);

lpinca
lpinca approved these changes Nov 6, 2018
View reviewed changes
test/parallel/test-child-process-no-deprecation.js Outdated
// spawn self as child
const child = spawn(process.argv[0], [process.argv[1], 'child']);

child.stderr.setEncoding('utf8');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
child.stderr.setEncoding('utf8');

jasnell
jasnell approved these changes Nov 10, 2018
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the suggested changes

@oyyd
Copy link
Contributor

oyyd commented Nov 13, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18571/

@gireeshpunathil
Copy link
Member

@richardlau @lpinca PTAL

@gireeshpunathil gireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2018
@gireeshpunathil
Copy link
Member

landed as 6ae6383 , thanks

gireeshpunathil pushed a commit that referenced this pull request Nov 13, 2018
@razvanbh @gireeshpunathil
test: add process no deprecation
6ae6383 
PR-URL: #24196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@razvanbh @BridgeAR
test: add process no deprecation
b6d2819 
PR-URL: #24196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@razvanbh @kiyomizumia
test: add process no deprecation
eb1b9df 
PR-URL: nodejs#24196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@razvanbh @codebytere
test: add process no deprecation
fbdfd60 
PR-URL: #24196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@razvanbh @oyyd @gireeshpunathil @jasnell @addaleax @lpinca @richardlau @BridgeAR @nodejs-github-bot