-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix some inconsistent use of hostname #24199
doc: fix some inconsistent use of hostname #24199
Conversation
12995ae
to
5b064f3
Compare
I think there reason why we decided to normalize everything to hostname (we did it in a "recent" PR if I remember correctly) is: const url = new URL('http://127.0.0.1:8080/');
console.log(url.host); // => 127.0.0.1:8080
console.log(url.hostname); // => 127.0.0.1 |
I agee with #23572, this is continuation of it. The DNS APIs changed there accept host names (and not addresses). Which isn't actually like URL parsing at all, since URls can have addresses or host names in the @lpinca perhaps you can comment more specifically on some of the changes I propose? I know its a mixture of changes, from fixing unclear docs, to actual typos, or just what I consider to be oddities in examples, so if there are specific ones you think don't make sense that would help. Btw, I don't know what normalize means, but it is certainly not the case that all uses of host were replaced with hostname, see https://nodejs.org/api/net.html#net_server_listen_port_host_backlog_callback |
5b064f3
to
8f13453
Compare
I think I addressed the comments, can I have a re-review? |
970c394
to
81e8772
Compare
host names are DNS names, host addresses are IP addresses, and `host` arguments and options can be either.
81e8772
to
3774bf6
Compare
host names are DNS names, host addresses are IP addresses, and `host` arguments and options can be either. PR-URL: nodejs#24199 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Landed in 3833d69. |
host names are DNS names, host addresses are IP addresses, and `host` arguments and options can be either. PR-URL: #24199 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
host names are DNS names, host addresses are IP addresses, and `host` arguments and options can be either. PR-URL: nodejs#24199 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
host names are DNS names, host addresses are IP addresses, and `host` arguments and options can be either. PR-URL: #24199 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
host names are DNS names, host addresses are IP addresses, and `host` arguments and options can be either. PR-URL: #24199 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
host names are DNS names, host addresses are IP addresses, and
host
arguments and options can be either.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes