buffer: fix writeUInt16BE range check #24208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
buffer
Trott
reviewed
Nov 6, 2018
mscdex
force-pushed
the
buffer-fix-writeUInt16BE
branch
from
0885ec0
to
030f2a6
Compare
cjihrig
approved these changes
Nov 6, 2018
Trott
approved these changes
Nov 6, 2018
|
CI with test added: https://ci.nodejs.org/job/node-test-pull-request/18383/ |
Trott
added
the
author ready
addaleax
approved these changes
Nov 7, 2018
|
@addaleax Why would we not land this bug fix on 10.x? |
|
@mscdex This adds a throw for some input cases, for which we previously had unintended but consistent behaviour, and addressing this doesn’t seem critical. I would say that that disqualifies this for LTS (or technically even might make this semver-major). You can feel free to disagree, and remove the labels, if you feel really strongly about this? |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 8, 2018
Fixes: nodejs#24205 PR-URL: nodejs#24208 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in 5c201b6. |
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
Fixes: nodejs#24205 PR-URL: nodejs#24208 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Nov 15, 2018
Merged
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24205
CI: https://ci.nodejs.org/job/node-test-pull-request/18382/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes