Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix linting errors #24229

Closed
wants to merge 1 commit into from
Closed

doc: fix linting errors #24229

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 7, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Nov 7, 2018
@cjihrig
Copy link
Contributor Author

cjihrig commented Nov 7, 2018

It appears that this was caused by the order in which #24090 and #24094 were landed. cc: @Trott

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 7, 2018
@Trott
Copy link
Member

Trott commented Nov 7, 2018

Whoops! And thanks! 👍 here to fast-track.

@Trott
Copy link
Member

Trott commented Nov 7, 2018

(Insert my usual "wow, let's get that commit queue happening so this sort of stuff doesn't happen" comment.)

@Trott
Copy link
Member

Trott commented Nov 7, 2018

Landed in 12c0fd4

@Trott Trott closed this Nov 7, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 7, 2018
PR-URL: nodejs#24229
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@cjihrig cjihrig deleted the doc-lint branch November 7, 2018 18:24
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
PR-URL: #24229
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
PR-URL: nodejs#24229
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
codebytere pushed a commit that referenced this pull request Nov 29, 2018
PR-URL: #24229
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
PR-URL: #24229
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
PR-URL: #24229
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants