Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: https agent clientcertengine coverage #24248

Closed
wants to merge 1 commit into from
Closed

test: https agent clientcertengine coverage #24248

wants to merge 1 commit into from

Conversation

ovhemert
Copy link
Contributor

@ovhemert ovhemert commented Nov 8, 2018

Code path for clientCertEngine in getName was not covered by the test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 8, 2018
@Trott
Copy link
Member

Trott commented Nov 15, 2018

@ovhemert Can you indicate what line or lines of what file this is intended to add coverage for?

@Trott
Copy link
Member

Trott commented Nov 15, 2018

@Trott
Copy link
Member

Trott commented Nov 16, 2018

@ovhemert
Copy link
Contributor Author

It's for covering line 165..167 in lib/https.js:

Agent.prototype.getName = function getName(options) {
  ...
  if (options.clientCertEngine)
    name += options.clientCertEngine;
  ...

It checks that clientCertEngine will be added to the output.

cc: @Trott

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 17, 2018
PR-URL: nodejs#24248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 17, 2018

Landed in c3a0337.

@Trott Trott closed this Nov 17, 2018
targos pushed a commit that referenced this pull request Nov 18, 2018
PR-URL: #24248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #24248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
codebytere pushed a commit that referenced this pull request Jan 12, 2019
PR-URL: #24248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
codebytere pushed a commit that referenced this pull request Jan 29, 2019
PR-URL: #24248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants