Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: check minimum ICU in configure for system-icu #24255

Merged
merged 1 commit into from
Nov 17, 2018

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Nov 8, 2018

  • check the version number coming out of pkg-config

Fixes: #24253

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Nov 8, 2018
@srl295 srl295 self-assigned this Nov 8, 2018
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 8, 2018
@srl295
Copy link
Member Author

srl295 commented Nov 8, 2018

else you get this:

root@4f4928358b09:/src/node# ./configure --with-intl=system-icu
ERROR: icu4c v60.2 is too old, v99.x or later is required.

also updates config.gypi, which wasn't set before. (icu_system_version is new here. icu_ver_major was set by the 'icu generic.gyp' code path, but not by system-icu previously)

                 'icu_system_version': '60.2',
                 'icu_ver_major': '60',

configure.py Outdated Show resolved Hide resolved
configure.py Outdated Show resolved Hide resolved
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nothing uses/is going to use icu_system_version, can you remove it?

configure.py Outdated Show resolved Hide resolved
configure.py Outdated Show resolved Hide resolved
@srl295
Copy link
Member Author

srl295 commented Nov 8, 2018

@bnoordhuis I'll remove icu_system_version but keep icu_ver_major for consistency with the other path.

@srl295
Copy link
Member Author

srl295 commented Nov 8, 2018

@bnoordhuis thanks. I think I addressed your comments.

Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment.

configure.py Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Nov 16, 2018

@srl295 Looks like there's one nit from @bnoordhuis and a CI run and otherwise this is landable? Does that seem right to you?

@refack
Copy link
Contributor

refack commented Nov 16, 2018

@refack
Copy link
Contributor

refack commented Nov 16, 2018

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 17, 2018
- check the version number coming out of pkg-config

PR-URL: nodejs#24255
Fixes: nodejs#24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@refack refack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 17, 2018
@refack refack merged commit ed1c40e into nodejs:master Nov 17, 2018
targos pushed a commit that referenced this pull request Nov 18, 2018
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
codebytere pushed a commit that referenced this pull request Jan 12, 2019
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
codebytere pushed a commit that referenced this pull request Jan 29, 2019
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants