New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: add HandleScopes to C++ embedder/addon API #24285

Closed

addaleax wants to merge 1 commit into nodejs:master from addaleax:async-handle-scopes

Commits on Nov 10, 2018

async_hooks: add HandleScopes to C++ embedder/addon API

Add `HandleScope`s to the public C++ API for embedders/addons,
since these methods create V8 handles that should not leak into
the outer scopes.

In particular, for some of the methods it was not clear from
the function signatures that these functions previously
needed to be invoked with a `HandleScope`.

addaleax committed Nov 10, 2018