test: fix flaky test-vm-timeout-escape-queuemicrotask #24296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stress test against master, will hopefully show failures: https://ci.nodejs.org/view/All/job/node-stress-single-test-pi1-fanned/102/ |
|
Stress test against this PR in its current form: https://ci.nodejs.org/view/All/job/node-stress-single-test-pi1-fanned/103/ |
Trott
added
fast-track
|
Pi1 on master had 67 failures in 100 runs. With this PR, 0 failures in 100 runs. Let's land this... |
|
Requesting fast-track. Collaborators, please 👍 here to approve. |
Use a larger timeout on slower platforms so that the timeout doesn't fire before the error condition occurs.
|
Force-pushed a change. Only difference is that I removed this test from flaky status in known_issues.status file. |
Trott
added
the
flaky-test
|
@nodejs/testing |
lpinca
approved these changes
Nov 11, 2018
BridgeAR
approved these changes
Nov 12, 2018
BridgeAR
added
the
author ready
fhinkel
approved these changes
Nov 13, 2018
|
Landed in 8e3c5b5 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 13, 2018
Use a larger timeout on slower platforms so that the timeout doesn't fire before the error condition occurs. PR-URL: nodejs#24296 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
Use a larger timeout on slower platforms so that the timeout doesn't fire before the error condition occurs. PR-URL: #24296 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
Use a larger timeout on slower platforms so that the timeout doesn't fire before the error condition occurs. PR-URL: nodejs#24296 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a larger timeout on slower platforms so that the timeout doesn't
fire before the error condition occurs.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes