tools: enable space-after-keywords eslint rule

[brendanashworth]

This adds a new eslint rule: space-after-keywords.

Spaces after keywords makes this error (6 now fixed errors):

if(x) { ... }

in favor of:

if (x) { ... }

[cjihrig]

I like it. LGTM

[targos]

LGTM

[bnoordhuis]

Not a big fan of new-cap. new clazz() makes it clear you're instantiating from a variable, new Clazz() not so much.

[brendanashworth]

new clazz() makes it clear you're instantiating from a variable, new Clazz() not so much.

Would you prefer the tests be refractored so no arguments are called with new?

[bnoordhuis]

No, I just don't think newIsCap is a very good rule. I'd leave it out.

[brendanashworth]

PTAL @bnoordhuis, i've removed the rule.

[bnoordhuis]

LGTM

[brendanashworth]

Thank you, landed in 8af5962 and 96a2b2d.

[cjihrig]

@brendanashworth did you include the commit metadata on those?

[brendanashworth]

Oh no, looks like I missed that.. a little bit late but thank you for
catching it. I'll comment on the commits.

On Saturday, August 22, 2015, Colin Ihrig notifications@github.com wrote:

@brendanashworth https://github.com/brendanashworth did you include the
commit metadata on those?

—
Reply to this email directly or view it on GitHub
#2430 (comment).