Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade to libuv 1.24.0 #24332

Merged
merged 1 commit into from
Nov 15, 2018
Merged

deps: upgrade to libuv 1.24.0 #24332

merged 1 commit into from
Nov 15, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 13, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1591/pipeline

@nodejs-github-bot nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Nov 13, 2018
@targos
Copy link
Member

targos commented Nov 13, 2018 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/18573/ (:heavy_check_mark:)

@addaleax
Copy link
Member

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1616/

trivikr
trivikr approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@bricss bricss mentioned this pull request Nov 14, 2018
Merged
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 15, 2018
@Trott
Copy link
Member

Trott commented Nov 15, 2018

@nodejs/citgm Any comments on the CITGM results?

@cjihrig
deps: upgrade to libuv 1.24.0
9cef7b8 
PR-URL: nodejs#24332
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@cjihrig cjihrig merged commit 9cef7b8 into nodejs:master Nov 15, 2018
@cjihrig cjihrig deleted the libuv branch November 15, 2018 19:55
targos pushed a commit that referenced this pull request Nov 18, 2018
@cjihrig @targos
deps: upgrade to libuv 1.24.0
b73a6e1 
PR-URL: #24332
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@cjihrig @rvagg
deps: upgrade to libuv 1.24.0
06c28b9 
PR-URL: #24332
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
@BridgeAR
Copy link
Member

BridgeAR commented Dec 7, 2018

It seems like this patch breaks a test on Node.js 11 on OS-X (https://ci.nodejs.org/job/node-test-commit-osx/23290/nodes=osx1011/console).

@BridgeAR
Copy link
Member

BridgeAR commented Dec 7, 2018 •
edited
Loading

The change landed after the update, so @targos and me decided to keep libuv but to pull out the change with the failing test. Please nevertheless have a close look at the failing test #20640.

This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@cjihrig @codebytere
deps: upgrade to libuv 1.24.0
72f10a4 
PR-URL: #24332
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
@MylesBorins MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 29, 2019
@MylesBorins
Copy link
Contributor

Should this be semver-minor? I feel like updated libuv should be but we haven't had an explicit policy around it. Happy to open another issue.

BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@cjihrig @BethGriggs
deps: upgrade to libuv 1.24.0
fcb61f8 
PR-URL: #24332
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@cjihrig @BethGriggs
deps: upgrade to libuv 1.24.0
3f3f833 
PR-URL: #24332
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request May 2, 2019
Closed
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@cjihrig @MylesBorins
deps: upgrade to libuv 1.24.0
74f4741 
PR-URL: #24332
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@addaleax addaleax addaleax approved these changes

@santigimeno santigimeno santigimeno approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. libuv Issues and PRs related to the libuv dependency or the uv binding. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.