http: compat head request should not start finished #24339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v6.x
http2
ronag
force-pushed
the
fix-head-finished2
branch
from
0121836
to
9e01a2f
Compare
ronag
changed the title
4 tasks
ronag
force-pushed
the
fix-head-finished2
branch
from
9e01a2f
to
a2c1683
Compare
ronag
force-pushed
the
fix-head-finished2
branch
from
a2c1683
to
216f1d0
Compare
ronag
force-pushed
the
fix-head-finished2
branch
from
216f1d0
to
4f8a5db
Compare
ronag
force-pushed
the
fix-head-finished2
branch
from
4f8a5db
to
9f74907
Compare
ronag
force-pushed
the
fix-head-finished2
branch
from
9f74907
to
ed1cf8c
Compare
ronag
force-pushed
the
fix-head-finished2
branch
from
ed1cf8c
to
7c4af8f
Compare
ronag
force-pushed
the
fix-head-finished2
branch
from
7c4af8f
to
d0adef3
Compare
http2 streams for HEAD requests are never writable, thus writableState is not interesting for checking whether a response is ended or aborted. Refs: nodejs#24283 PR-URL: nodejs#24339
ronag
force-pushed
the
fix-head-finished2
branch
from
d0adef3
to
94d6f69
Compare
|
Fixed commit msg to pass CI. |
|
I suggest we wait to see what happens with #24347 before merging this. |
|
Close in favour of #24347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http2 streams for HEAD requests are never writable, thus writableState is not interesting for checking whether a response is ended or aborted.
Refs: #24283
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes