Add missing secureProtocol values, and some docs on protocol selection #24386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Trott
reviewed
Nov 16, 2018
doc/api/cli.md
Outdated
| clients or servers. | ||
| Enable TLSv1.0 and TLSv1.1 by default, in addition to TLSv1.2. This should only | ||
| be used for compatibility with old TLS clients or servers. See | ||
| [secureProtocol][] for more information. |
There was a problem hiding this comment.
Maybe this?:
Enable TLSv1.0 and TLSv1.1 by default. Use only
for compatibility with old TLS clients or servers. See
[secureProtocol][] for more information.There was a problem hiding this comment.
You removed the "in addition to TLSv1.2". Why? I guess one could argue that saying TLSv1.0 and 1.1 are enabled by default doesn't necessarily mean that ONLY TLS 1.0 and 1.1 are enabled by default, but I don't like to leave people wondering. Lets tell them exactly what will be enabled.
There was a problem hiding this comment.
I'm happy to s/This should only be used/Use for/.
Trott
reviewed
Nov 16, 2018
Trott
reviewed
Nov 16, 2018
Trott
reviewed
Nov 16, 2018
Trott
reviewed
Nov 16, 2018
sam-github
force-pushed
the
more-secure-protocols
branch
from
af40ac7 to
818c1eb
Compare
This comment has been minimized.
This comment has been minimized.
sam-github
force-pushed
the
more-secure-protocols
branch
from
818c1eb to
25acf88
Compare
Add the two TLS protocol method functions which were missing. They seem useful, and are already documented as being supported (indirectly, our docs just point to OpenSSL's docs).
Cross-reference the secureProtocol docs and the CLI docs for --tls-v1.0 and --tls-v1.1 and describe relationship. Make clear that --tls-v1.0 enables TLSv1.0 and TLSv1.1.
sam-github
force-pushed
the
more-secure-protocols
branch
from
25acf88 to
1032db1
Compare
4 tasks
|
@nodejs/crypto @nodejs/documentation |
danbev
approved these changes
Nov 19, 2018
|
Landed in eb42c1e...4327326 |
sam-github
added a commit
that referenced
this pull request
Nov 19, 2018
Add the two TLS protocol method functions which were missing. They seem useful, and are already documented as being supported (indirectly, our docs just point to OpenSSL's docs). PR-URL: #24386 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
sam-github
added a commit
that referenced
this pull request
Nov 19, 2018
Cross-reference the secureProtocol docs and the CLI docs for --tls-v1.0 and --tls-v1.1 and describe relationship. Make clear that --tls-v1.0 enables TLSv1.0 and TLSv1.1. PR-URL: #24386 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
|
Should this be backported to |
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Add the two TLS protocol method functions which were missing. They seem useful, and are already documented as being supported (indirectly, our docs just point to OpenSSL's docs). PR-URL: nodejs#24386 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Cross-reference the secureProtocol docs and the CLI docs for --tls-v1.0 and --tls-v1.1 and describe relationship. Make clear that --tls-v1.0 enables TLSv1.0 and TLSv1.1. PR-URL: nodejs#24386 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes