Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update 11.0.0 changelog with missing commit #24404

Closed
wants to merge 3 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 16, 2018

Fixes: #23846

Please 👍 here to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott Trott added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 16, 2018
@Trott Trott closed this Nov 16, 2018
@refack refack removed the fast-track PRs that do not need to wait for 48 hours to land. label Nov 16, 2018
@Trott Trott reopened this Nov 16, 2018
@Trott
Copy link
Member Author

Trott commented Nov 16, 2018

So, this is a little strange in that the commit is manually inserted into the 11.0.0 semver-major list even though it was introduced (by accidentally overlooking the semver-ness) in 10.x, where it was subsequently reverted. But we still want to note it in 11.0.0. So, although there may be a better way to do it, I've inserted it into the normal flow. That has to be better than omitting it at least, right?

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 16, 2018
@Trott
Copy link
Member Author

Trott commented Nov 16, 2018

@refack
Copy link
Contributor

refack commented Nov 16, 2018

That has to be better than omitting it at least, right?

The remaining issue is that it's not in the blog post, and our detailed semver major changes list, and recommended workarounds.

@Trott
Copy link
Member Author

Trott commented Nov 17, 2018

The remaining issue is that it's not in the blog post,

nodejs/nodejs.org#1900

@danbev
Copy link
Contributor

danbev commented Nov 20, 2018

Landed in b32c5f0.

@danbev danbev closed this Nov 20, 2018
danbev pushed a commit that referenced this pull request Nov 20, 2018
PR-URL: #24404
Fixes: #23846
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos pushed a commit that referenced this pull request Nov 20, 2018
PR-URL: #24404
Fixes: #23846
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #24404
Fixes: #23846
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24404
Fixes: nodejs#23846
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@Trott Trott deleted the changelog-fix branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing semver-major change in v11.0.0 changelog
5 participants