-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update 11.0.0 changelog with missing commit #24404
Conversation
So, this is a little strange in that the commit is manually inserted into the 11.0.0 semver-major list even though it was introduced (by accidentally overlooking the semver-ness) in 10.x, where it was subsequently reverted. But we still want to note it in 11.0.0. So, although there may be a better way to do it, I've inserted it into the normal flow. That has to be better than omitting it at least, right? |
The remaining issue is that it's not in the blog post, |
|
Landed in b32c5f0. |
PR-URL: nodejs#24404 Fixes: nodejs#23846 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Fixes: #23846
Please 👍 here to fast-track.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes