Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix the arguments order in assert.strictEqual #24416

Closed
wants to merge 1 commit into from
Closed

test: fix the arguments order in assert.strictEqual #24416

wants to merge 1 commit into from

Conversation

jarthana
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
oyyd
oyyd approved these changes Nov 17, 2018
View reviewed changes
Copy link
Contributor

@oyyd oyyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM.

Commit message should say "fix" instead of "fixed"

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2018
@targos
Copy link
Member

targos commented Nov 17, 2018

👍 to fast-track

@gireeshpunathil
Copy link
Member

@jarthana - please see if you can make the changes that @targos suggested. It is something that we can do while landing; but appreciate if you make an attempt, as doing so strengthens the learning, to the spirit of the code & learn, thanks!

@jarthana jarthana changed the title test: fixed the arguments order in assert.strictEqual test: fix the arguments order in assert.strictEqual Nov 19, 2018
@Trott
Copy link
Member

Trott commented Nov 19, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18743/

@gireeshpunathil gireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 19, 2018
@gireeshpunathil
Copy link
Member

all clean. Wait for either one more fast-track 👍 or 72 hours whichever comes first.

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 19, 2018
@jarthana @Trott
test: fix the arguments order in assert.strictEqual
092ab7a 
PR-URL: nodejs#24416
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 19, 2018

Landed in 092ab7a

@Trott Trott closed this Nov 19, 2018
targos pushed a commit that referenced this pull request Nov 19, 2018
@jarthana @targos
test: fix the arguments order in assert.strictEqual
b7215ea 
PR-URL: #24416
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jarthana @rvagg
test: fix the arguments order in assert.strictEqual
0a08cd7 
PR-URL: #24416
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@jarthana @codebytere
test: fix the arguments order in assert.strictEqual
e41833f 
PR-URL: #24416
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@jarthana @refack
test: fix the arguments order in assert.strictEqual
cbd9cac 
PR-URL: nodejs#24416
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@jarthana @codebytere
test: fix the arguments order in assert.strictEqual
abe9778 
PR-URL: #24416
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@oyyd oyyd oyyd approved these changes

@sagirk sagirk sagirk approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jarthana @targos @gireeshpunathil @Trott @jasnell @cjihrig @sagirk @oyyd @trivikr @nodejs-github-bot