Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced anonymous closure functions with arrow function #24420

Closed
wants to merge 1 commit into from
Closed

replaced anonymous closure functions with arrow function #24420

wants to merge 1 commit into from

Conversation

IamDixit
Copy link

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
targos
targos approved these changes Nov 17, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Commit message should start with test: replace ...

@targos
Copy link
Member

targos commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2018
@gireeshpunathil
Copy link
Member

@IamDixit - please see if you can make the changes that @targos suggested. It is something that we can do while landing; but appreciate if you make an attempt, as doing so strengthens the learning, to the spirit of the code & learn, thanks!

error details in the CI log (line 587)
https://travis-ci.com/nodejs/node/jobs/159273466

@gireeshpunathil
Copy link
Member

also your email ID is not associated with the git configuration. please follow step 1 in https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#dependencies before you push changes again.

@Trott Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Nov 18, 2018
@Trott
Copy link
Member

Trott commented Nov 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18787/

@Trott
Copy link
Member

Trott commented Nov 20, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18817/

@Trott
Copy link
Member

Trott commented Nov 20, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18822/

@Trott
Copy link
Member

Trott commented Nov 21, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18828/

@Trott
Copy link
Member

Trott commented Nov 21, 2018

Landed in 62fe416

@Trott Trott closed this Nov 21, 2018
@Trott
Copy link
Member

Trott commented Nov 21, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 21, 2018
@Trott
test: replace anonymous closure functions with arrow function
62fe416 
PR-URL: nodejs#24420
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 21, 2018
@targos
test: replace anonymous closure functions with arrow function
5785e4e 
PR-URL: #24420
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gireeshpunathil gireeshpunathil mentioned this pull request Nov 22, 2018
Closed
4 tasks
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@rvagg
test: replace anonymous closure functions with arrow function
fbb228b 
PR-URL: #24420
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request Dec 8, 2018
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@codebytere
test: replace anonymous closure functions with arrow function
1f5a5a7 
PR-URL: #24420
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
test: replace anonymous closure functions with arrow function
e827120 
PR-URL: nodejs#24420
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@codebytere
test: replace anonymous closure functions with arrow function
283a6b8 
PR-URL: #24420
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@sagirk sagirk sagirk approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@IamDixit @targos @gireeshpunathil @Trott @jasnell @cjihrig @sagirk @trivikr @nodejs-github-bot