Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move test-stream-pipeline.js to sequential #24464

Closed
wants to merge 1 commit into from
Closed

test: move test-stream-pipeline.js to sequential #24464

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Nov 18, 2018

Fixes: #24456

In case the tests in #24456 (comment) prove the hypothesis.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 18, 2018
@refack refack added stream Issues and PRs related to the stream subsystem. windows Issues and PRs related to the Windows platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. wip Issues and PRs that are still a work in progress. labels Nov 18, 2018
@refack
Copy link
Contributor Author

refack commented Nov 18, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18726/

@refack refack added abandoned and removed wip Issues and PRs that are still a work in progress. labels Nov 18, 2018
@refack
Copy link
Contributor Author

refack commented Nov 18, 2018

Stress test seems to indicate > 5% fails even when run with -j1 - https://ci.nodejs.org/job/node-stress-single-test/nodes=win2008r2-mp-vs2017/2084/console

@refack refack closed this Nov 18, 2018
@refack refack deleted the sequentialize-test-stream-pipeline branch November 18, 2018 18:12
@refack refack restored the sequentialize-test-stream-pipeline branch March 11, 2019 15:32
@refack refack deleted the sequentialize-test-stream-pipeline branch April 14, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky: test-stream-pipeline-http2
2 participants
@refack @nodejs-github-bot