Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x] Fix abi break #24499

Closed
wants to merge 2 commits into from
Closed

[v8.x] Fix abi break #24499

wants to merge 2 commits into from

Commits on Nov 20, 2018

  1. deps: V8: partially revert d868eb7 

    d868eb7 ended up being an inadvertant ABI change. Remove the call to
CheckMemoryPressure from the header itself.
    @ofrobots
    ofrobots committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    0cad314 View commit details
    Browse the repository at this point in the history

  2. src,deps: add ABI safe use of CheckMemoryPressure 

    CheckMemoryPressure cannot be used ABI-safely from v8.h. Add a alternate
implementation of AdjustAmountOfExternalAllocatedMemory and then use
that from Node.
    @ofrobots
    ofrobots committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    dc1bd96 View commit details
    Browse the repository at this point in the history