lib: changed bootstrap/node.js to arrow function #24625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Nov 24, 2018
lib/internal/bootstrap/node.js
Outdated
| @@ -389,13 +389,13 @@ | |||
| const util = NativeModule.require('util'); | |||
|
|
|||
| function makeGetter(name) { | |||
| return util.deprecate(function() { | |||
| return util.deprecate(() => { | |||
| return this; | |||
There was a problem hiding this comment.
Some of these functions use this, so I think converting them to an arrow function would break them?
There was a problem hiding this comment.
thanks! I'll change that part back to function
Leko
added
code-and-learn
Naturalclar
force-pushed
the
bootstrap_node.js-change-to-arrow-function
branch
from
94271d4
to
cfd900d
Compare
oyyd
reviewed
Nov 24, 2018
lib/internal/bootstrap/node.js
Outdated
| @@ -395,7 +395,7 @@ | |||
| } | |||
|
|
|||
| function makeSetter(name) { | |||
| return util.deprecate(function(value) { | |||
| return util.deprecate((value) => { | |||
| Object.defineProperty(this, name, { | |||
There was a problem hiding this comment.
this is used here so that we should not change here, should we?
There was a problem hiding this comment.
sorry, missed that part. I'll change that part back to function as well
Leko
approved these changes
Nov 26, 2018
Naturalclar
changed the title
shisama
approved these changes
Nov 28, 2018
|
Landed in 0f18a40 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 29, 2018
PR-URL: nodejs#24625 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
|
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #24625 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24625 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24625 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24625 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
fix function declarations to arrow functions in lib/internal/bootstrap/node.js
make -j4 test(UNIX), orvcbuild test(Windows) passes