Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: prepare test/message/testcfg.py for Python 3 #24793

Closed
wants to merge 1 commit into from
Closed

test: prepare test/message/testcfg.py for Python 3 #24793

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 3, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 3, 2018
@Trott
Copy link
Member

Trott commented Dec 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19254/

@Trott
Copy link
Member

Trott commented Dec 6, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19263/

@Trott Trott added the python PRs and issues that require attention from people who are familiar with Python. label Dec 6, 2018
@Trott
Copy link
Member

Trott commented Dec 6, 2018

@nodejs/python This could use another review.

@Trott
Copy link
Member

Trott commented Dec 7, 2018 •
edited
Loading

Landed in 87592d1

@Trott Trott closed this Dec 7, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 7, 2018
@Trott
test: prepare test/message/testcfg.py for Python 3
87592d1 
PR-URL: nodejs#24793
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@cclauss cclauss deleted the Py3-for-test_message_testcfg.py branch December 7, 2018 05:39
MylesBorins pushed a commit that referenced this pull request Dec 7, 2018
@MylesBorins
test: prepare test/message/testcfg.py for Python 3
a5c8af7 
PR-URL: #24793
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
test: prepare test/message/testcfg.py for Python 3
e71333d 
PR-URL: nodejs#24793
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BethGriggs
test: prepare test/message/testcfg.py for Python 3
b1bbac7 
PR-URL: #24793
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@BethGriggs
test: prepare test/message/testcfg.py for Python 3
12de38d 
PR-URL: #24793
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@rvagg
test: prepare test/message/testcfg.py for Python 3
752ef34 
PR-URL: #24793
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cclauss @Trott @richardlau @nodejs-github-bot