Update cares_wrap.cc to make it clear #2488
Conversation
fix comment
fix comments to make it clear
Update cares_wrap.cc
|
LGTM |
|
@jasnell Thanks! |
|
Can I ask you to please squash the commits down to a single commit and update the log to fit the guideline here: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit |
|
@jasnell Sure, I will |
|
Since this is getting stale and comments from @Fishrock123 and @trevnorris in #2071 indicate that these sorts of typo fixes are generally not landed without a really good reason, I'm going to go ahead and close this. Feel free to re-open if it's active or there's a difference of opinion. I don't feel strongly about it personally. But I prefer to close PRs that can be closed if they're older than a week or so. |
|
Just adding to above -- since c-ares is a project we pull from upstream (albeit with minor changes), I'd suggest you post the patch for landing at their place instead. |
fix comments to make it clear