Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use isolate version of BooleanValue() #24883

Closed
wants to merge 1 commit into from
Closed

src: use isolate version of BooleanValue() #24883

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 7, 2018

This fixes deprecation warnings.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
src: use isolate version of BooleanValue()
d509e0d 
This fixes deprecation warnings.
@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1858/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 7, 2018
@Trott
Copy link
Member

Trott commented Dec 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19345/ ✔️

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 9, 2018
@Trott
Copy link
Member

Trott commented Dec 9, 2018

Landed in 24e6b70

@Trott Trott closed this Dec 9, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 9, 2018
@cjihrig @Trott
src: use isolate version of BooleanValue()
24e6b70 
This fixes deprecation warnings.

PR-URL: nodejs#24883
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@cjihrig cjihrig deleted the boolval branch December 9, 2018 17:38
@BethGriggs
Copy link
Member

This landed cleanly on v11.x-staging, but caused some compile errors - does it need a backport?

@sam-github
Copy link
Contributor

The Isolate version of BooleanValue only exists on master, using an API from v8 7.1.302.28, so unless v8 gets updated on 11.x this change can't backport.

refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
src: use isolate version of BooleanValue()
3b00382 
This fixes deprecation warnings.

PR-URL: nodejs#24883
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cjihrig @nodejs-github-bot @Trott @BethGriggs @sam-github @danbev @addaleax @targos @joyeecheung