Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: prepare test/pseudo-tty/testcfg.py for Python 3 #24887

Closed
wants to merge 1 commit into from
Closed

test: prepare test/pseudo-tty/testcfg.py for Python 3 #24887

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 7, 2018

reduce() was moved into functools in Python 3

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Dec 7, 2018
@Trott
Copy link
Member

Trott commented Dec 7, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19310/

@Trott
Copy link
Member

Trott commented Dec 10, 2018 •
edited by danbev
Loading

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19372/

@danbev
Copy link
Contributor

danbev commented Dec 11, 2018

Re-running failing node-test-commit-linux

@Trott
Copy link
Member

Trott commented Dec 11, 2018 •
edited by danbev
Loading

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19415 ✔️

@danbev
Copy link
Contributor

danbev commented Dec 11, 2018

Landed in b337b58.

@danbev danbev closed this Dec 11, 2018
danbev pushed a commit that referenced this pull request Dec 11, 2018
@danbev
test: prepare test/pseudo-tty/testcfg.py Python 3
b337b58 
PR-URL: #24887
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@cclauss cclauss deleted the Py3-for-test_pseudo-tty branch December 11, 2018 10:16
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
@BethGriggs
test: prepare test/pseudo-tty/testcfg.py Python 3
bc71e9e 
PR-URL: #24887
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
test: prepare test/pseudo-tty/testcfg.py Python 3
d1133af 
PR-URL: nodejs#24887
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BethGriggs
test: prepare test/pseudo-tty/testcfg.py Python 3
a67d37d 
PR-URL: #24887
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@BethGriggs
test: prepare test/pseudo-tty/testcfg.py Python 3
b726b87 
PR-URL: #24887
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@rvagg
test: prepare test/pseudo-tty/testcfg.py Python 3
a4623b4 
PR-URL: #24887
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cclauss @Trott @danbev @BethGriggs @nodejs-github-bot