test: split test-cli-syntax into multiple tests #24922
Conversation
|
Refs: #24403 |
|
At least to see what happens, CI: https://ci.nodejs.org/job/node-test-pull-request/19357/ |
|
With this change, it's the file-not-found test that failed in CI, which is the typical part that failed in the more monolithic version of the test. But I guess we (meaning @addaleax and perhaps some other people-who-aren't-me) already knew that it wasn't failing because of side effects. https://ci.nodejs.org/job/node-test-commit-aix/19542/nodes=aix61-ppc64/console on test-osuosl-aix61-ppc64_be-1 10:45:19 not ok 2383 sequential/test-cli-syntax-file-not-found
10:45:19 ---
10:45:19 duration_ms: 2.6
10:45:19 severity: fail
10:45:19 exitcode: 1
10:45:19 stack: |-
10:45:19 assert.js:86
10:45:19 throw new AssertionError(obj);
10:45:19 ^
10:45:19
10:45:19 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
10:45:19
10:45:19 null !== 1
10:45:19
10:45:19 at common.mustCall (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/sequential/test-cli-syntax-file-not-found.js:36:14)
10:45:19 at /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/common/index.js:346:15
10:45:19 at ChildProcess.exithandler (child_process.js:301:5)
10:45:19 at ChildProcess.emit (events.js:189:13)
10:45:19 at maybeClose (internal/child_process.js:978:16)
10:45:19 at Process.ChildProcess._handle.onexit (internal/child_process.js:265:5)
10:45:19 ... |
|
Oh, with this change, we can probably move some or all of these back to |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19367/ |
|
On Resume Build, it was test/sequential/test-cli-syntax-bad and test/sequential/test-cli-syntax-file-not-found. I was hoping splitting it up would result in the error occurring in a more consistent way, but I guess not. It's still all over the place... |
|
Rebased to remove conflict. Updated $ tools/test.py -j 96 --repeat 192 test/parallel/test-cli-syntax-*
[00:48|% 100|+ 576|- 0]: Done
$ |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19458/ |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19469/ |
Split test-cli-syntax into multiple files to improve reliability and/or isolate unreliable test cases. Move test cases back to parallel as appropriate.
|
Landed in a3801e9 |
Split test-cli-syntax into multiple files to improve reliability and/or isolate unreliable test cases. Move test cases back to parallel as appropriate. PR-URL: nodejs#24922 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Split test-cli-syntax into multiple files to improve reliability and/or isolate unreliable test cases. Move test cases back to parallel as appropriate. PR-URL: #24922 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Split test-cli-syntax into multiple files to improve reliability and/or isolate unreliable test cases. Move test cases back to parallel as appropriate. PR-URL: nodejs#24922 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Split test-cli-syntax into multiple files to improve reliability and/or isolate unreliable test cases. Move test cases back to parallel as appropriate. PR-URL: #24922 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Split test-cli-syntax into multiple files to improve reliability and/or
isolate unreliable test cases.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes