Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trace_events: fix trace events JS API not writing traces #24945

Closed
wants to merge 1 commit into from
Closed

trace_events: fix trace events JS API not writing traces #24945

wants to merge 1 commit into from

Commits on Feb 14, 2019

  1. trace_events: fix trace events JS API not writing traces 

    The Trace Events JS API isn't functional if none of
--trace-events-enabled or --trace-event-categories is passed as a CLI
argument. This commit fixes that.

In addition, we currently don't test the trace_events JS API in the case where no CLI
args are provided. This commit adds that test.

Fixes nodejs#24944
    @kjin
    kjin committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    6d6d36f View commit details
    Browse the repository at this point in the history