Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove internalBinding('config').pendingDeprecation #24962

Closed
wants to merge 2 commits into from
Closed

lib: remove internalBinding('config').pendingDeprecation #24962

wants to merge 2 commits into from

Conversation

joyeecheung
Copy link
Member

Instead use
require('internal/options').getOptionValue('--pending-deprecation')

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@joyeecheung
lib: remove internalBinding('config').pendingDeprecation
491fcc8 
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`
@nodejs-github-bot
Copy link
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1896/pipeline

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Dec 11, 2018
BridgeAR
BridgeAR approved these changes Dec 12, 2018
View reviewed changes
test/parallel/test-pending-deprecation.js Outdated
}

switch (process.argv[2]) {
case 'env':
case 'switch':
assert.strictEqual(config.pendingDeprecation, true);
assert.strictEqual(
require('internal/options').getOptionValue('--pending-deprecation'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to move this to the top of the file as in: const { getOptionvalue } = require('internal/options');. It's always loaded anyway.

lib/buffer.js Show resolved Hide resolved
@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 14, 2018
@Trott
Copy link
Member

Trott commented Dec 15, 2018 •
edited
Loading

Only failure in CI was AIX which failed because there was a leftover process at the end of all the tests. 😱Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19552/ ✔️

@Trott
Copy link
Member

Trott commented Dec 15, 2018

Landed in b32e5e0

@Trott Trott closed this Dec 15, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 15, 2018
@joyeecheung @Trott
lib: remove internalBinding('config').pendingDeprecation
b32e5e0 
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`

PR-URL: nodejs#24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
sagitsofan pushed a commit to sagitsofan/node that referenced this pull request Dec 24, 2018
@joyeecheung @sagitsofan
lib: remove internalBinding('config').pendingDeprecation
b3e8d37 
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`

PR-URL: nodejs#24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins
Copy link
Contributor

This does not land cleanly on v11.x, would someone be willing to backport?

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 9, 2019
@joyeecheung @BridgeAR
lib: remove internalBinding('config').pendingDeprecation
57a5b97 
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`

PR-URL: nodejs#24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jan 9, 2019
Closed
4 tasks
BridgeAR pushed a commit that referenced this pull request Jan 10, 2019
@joyeecheung @BridgeAR
lib: remove internalBinding('config').pendingDeprecation
617bfe4 
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`

PR-URL: #24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
joyeecheung added a commit to joyeecheung/node that referenced this pull request Jan 11, 2019
@joyeecheung
lib: remove internalBinding('config').pendingDeprecation
4cb9036 
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`

PR-URL: nodejs#24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@joyeecheung @addaleax
lib: remove internalBinding('config').pendingDeprecation
207612c 
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`

PR-URL: #24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Backport-PR-URL: #25446
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@joyeecheung @refack
lib: remove internalBinding('config').pendingDeprecation
1cca4d8 
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`

PR-URL: nodejs#24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@joyeecheung @BridgeAR
lib: remove internalBinding('config').pendingDeprecation
68bc42a 
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`

PR-URL: nodejs#24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Backport-PR-URL: nodejs#25446
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@joyeecheung @nodejs-github-bot @Trott @MylesBorins @jasnell @addaleax @cjihrig @BridgeAR @BethGriggs