-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove dead code #25009
test: remove dead code #25009
Conversation
This is not used by the test anymore.
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed.
@@ -1,9 +1,7 @@ | |||
node_modules | |||
lib/internal/v8.js | |||
lib/internal/v8_prof_polyfill.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what this file does. Do we have to ignore the file here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My vague recollection: I think the file was originally copied from either V8 source or a V8 change proposal that may have been rejected by V8. Since we were copying the file, we didn't apply our lint style to it since we would just copy changes from upstream at a later date, presumably. This is similar, I think, to how we handle punycode.js. It looks like we may now basically own v8_prof_polyfill.js, though. I'm not sure. @matthewloring may know,.
This is not used by the test anymore. PR-URL: nodejs#25009 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed. PR-URL: nodejs#25009 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Landed in e7c3a1b...1395256 |
This is not used by the test anymore. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This is not used by the test anymore. PR-URL: nodejs#25009 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed. PR-URL: nodejs#25009 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This is not used by the test anymore. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This is not used by the test anymore. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This is not used by the test anymore. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This is not used by the test anymore.
I am uncertain why this is not found by eslint but I did not check.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes