Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: use strict comparisons for fd #25014

Merged
merged 1 commit into from
Dec 15, 2018
Merged

net: use strict comparisons for fd #25014

merged 1 commit into from
Dec 15, 2018

Commits on Dec 15, 2018

  1. net: use strict comparisons for fd 

    This commit removes an eslint-disable comment, and moves file
descriptor checks to use strict equality. These checks were
using loose equality to support numeric and string file
descriptors. However, d9e95d8
introduced strict validation, making the loose equality checks
redundant.

PR-URL: nodejs#25014
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    06134e3 View commit details
    Browse the repository at this point in the history