Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: make apilinks building more robust #25019

Closed
wants to merge 1 commit into from
Closed

tools: make apilinks building more robust #25019

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

  1. Move the apilinks.json file into out/doc so it gets cleaned when
    running make docclean
  2. When the apilinks.json generated is empty, throw a specific error
    so it's easier to understand what's wrong
  3. Write to a file passed through CLI arguments instead writing to
    stdout in apilinks.js so the build process is more robust in
    the case of a bad binary
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@joyeecheung
tools: make apilinks building more robust
1cbc5e7 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary
@nodejs-github-bot
Copy link
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1930/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Dec 13, 2018
@joyeecheung joyeecheung mentioned this pull request Dec 16, 2018
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Dec 17, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19596/ ✔️

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2018
@danbev
Copy link
Contributor

danbev commented Dec 18, 2018

Landed in 9190e4e.

@danbev danbev closed this Dec 18, 2018
danbev pushed a commit that referenced this pull request Dec 18, 2018
@joyeecheung @danbev
tools: make apilinks building more robust
9190e4e 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary

PR-URL: #25019
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@joyeecheung @MylesBorins
tools: make apilinks building more robust
a5bccc2 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary

PR-URL: #25019
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 25, 2018
Merged
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@joyeecheung @refack
tools: make apilinks building more robust
b2e771d 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary

PR-URL: nodejs#25019
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit to MylesBorins/build that referenced this pull request Jan 29, 2019
@MylesBorins
assets: additional asset for v11.x
c8119db 
Refs: nodejs/node#22405
Refs: nodejs/node#25019
@MylesBorins MylesBorins mentioned this pull request Jan 29, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@joyeecheung @BethGriggs
tools: make apilinks building more robust
027ca95 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary

PR-URL: #25019
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@joyeecheung @BethGriggs
tools: make apilinks building more robust
71fad31 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary

PR-URL: #25019
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit to nodejs/build that referenced this pull request Feb 28, 2019
@MylesBorins @rvagg
assets: additional asset for v11.x
6098487 
Refs: nodejs/node#22405
Refs: nodejs/node#25019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@joyeecheung @rvagg
tools: make apilinks building more robust
ef07faa 
1. Move the apilinks.json file into out/doc so it gets cleaned when
  running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
  so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
  stdout in apilinks.js so the build process is more robust in
  the case of a bad binary

PR-URL: #25019
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau added a commit to richardlau/build that referenced this pull request Apr 9, 2020
@richardlau
promote: add additional asset for v10.x
1f5e87b 
`docs/apilinks.json` was added in v10.15.3.

Refs: nodejs/node#25019
Refs: nodejs#1673

Signed-off-by: Richard Lau <riclau@uk.ibm.com>
@richardlau richardlau mentioned this pull request Apr 9, 2020
Merged
rvagg pushed a commit to nodejs/build that referenced this pull request Apr 13, 2020
@richardlau @rvagg
promote: add additional asset for v10.x
8c2444d 
`docs/apilinks.json` was added in v10.15.3.

Refs: nodejs/node#25019
Refs: #1673

Signed-off-by: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joyeecheung @nodejs-github-bot @Trott @danbev @jasnell @addaleax @BethGriggs