Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-worker-memory flaky on Windows CI #25042

Closed
wants to merge 1 commit into from
Closed

test: mark test-worker-memory flaky on Windows CI #25042

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 14, 2018

Collaborators, please 👍 to fast-track.

Refs: #23277

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. worker Issues and PRs related to Worker support. labels Dec 14, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1947/pipeline

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19518/

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19526/

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018 •
edited
Loading

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19534/ ✔️

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

Landed in 87006be

@Trott Trott closed this Dec 14, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 14, 2018
@Trott
test: mark test-worker-memory flaky on Windows CI
87006be 
Refs: nodejs#23277

PR-URL: nodejs#25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@Trott @BethGriggs
test: mark test-worker-memory flaky on Windows CI
2825894 
Refs: #23277

PR-URL: #25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
sagitsofan pushed a commit to sagitsofan/node that referenced this pull request Dec 24, 2018
@Trott @sagitsofan
test: mark test-worker-memory flaky on Windows CI
52a54c4 
Refs: nodejs#23277

PR-URL: nodejs#25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
test: mark test-worker-memory flaky on Windows CI
731db7b 
Refs: nodejs#23277

PR-URL: nodejs#25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@Trott @BethGriggs
test: mark test-worker-memory flaky on Windows CI
55680e3 
Refs: #23277

PR-URL: #25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@Trott @BethGriggs
test: mark test-worker-memory flaky on Windows CI
3a2a08d 
Refs: #23277

PR-URL: #25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott @rvagg
test: mark test-worker-memory flaky on Windows CI
241986d 
Refs: #23277

PR-URL: #25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott Trott deleted the mark-flaky-memory branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @cjihrig @gireeshpunathil @BethGriggs