Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-child-process-execfile flaky #25051

Closed
wants to merge 1 commit into from
Closed

test: mark test-child-process-execfile flaky #25051

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 14, 2018 •
edited
Loading

Collaborators, 👍 here to fast-track.

Refs: #25029

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Dec 14, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1955/pipeline

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19542/ ✔️

Trott added a commit to Trott/io.js that referenced this pull request Dec 15, 2018
@Trott
test: mark test-child-process-execfile flaky
6a24014 
Refs: nodejs#25029

PR-URL: nodejs#25051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott
Copy link
Member Author

Trott commented Dec 15, 2018

Landed in 6a24014

@Trott Trott closed this Dec 15, 2018
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@Trott @BethGriggs
test: mark test-child-process-execfile flaky
ac919ef 
Refs: #25029

PR-URL: #25051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
sagitsofan pushed a commit to sagitsofan/node that referenced this pull request Dec 24, 2018
@Trott @sagitsofan
test: mark test-child-process-execfile flaky
b657f75 
Refs: nodejs#25029

PR-URL: nodejs#25051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
test: mark test-child-process-execfile flaky
b00b4d6 
Refs: nodejs#25029

PR-URL: nodejs#25051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@Trott @BethGriggs
test: mark test-child-process-execfile flaky
dd2b553 
Refs: #25029

PR-URL: #25051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@Trott @BethGriggs
test: mark test-child-process-execfile flaky
ab5dedf 
Refs: #25029

PR-URL: #25051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott @rvagg
test: mark test-child-process-execfile flaky
67409ce 
Refs: #25029

PR-URL: #25051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott Trott deleted the execfile-flaky branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @cjihrig @richardlau @BethGriggs