-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark sequential/test-inspector-debug-end and parallel/test-child-process-execfile as flaky #25126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
approved these changes
Dec 19, 2018
sequential/test-inspector-debug-end and parallel/test-child-process-execfile Off late these have been failing in AIX. Debugging core dump suggested that this is a side effect of exit-race that is described in nodejs#25007 Mart these as flaky in AIX until that is resolved. Refs: nodejs#25047 Refs: nodejs#25029
gireeshpunathil
force-pushed
the
aix_flake
branch
from
December 19, 2018 08:59
364e919
to
c1ca1f4
Compare
added an entry for the issue pertinent to #25029 as well, in this. |
gireeshpunathil
changed the title
test: mark sequential/test-inspector-debug-end as flaky
test: mark sequential/test-inspector-debug-end and parallel/test-child-process-execfile as flaky
Dec 19, 2018
One week with a single approval, contemplating to land. |
gireeshpunathil
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Dec 27, 2018
jasnell
approved these changes
Dec 27, 2018
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19849/ |
landed as 7a867b8 |
gireeshpunathil
added a commit
that referenced
this pull request
Dec 28, 2018
sequential/test-inspector-debug-end and parallel/test-child-process-execfile Off late these have been failing in AIX. Debugging core dump suggested that this is a side effect of exit-race that is described in #25007 Mart these as flaky in AIX until that is resolved. Refs: #25047 Refs: #25029 PR-URL: #25126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 1, 2019
sequential/test-inspector-debug-end and parallel/test-child-process-execfile Off late these have been failing in AIX. Debugging core dump suggested that this is a side effect of exit-race that is described in #25007 Mart these as flaky in AIX until that is resolved. Refs: #25047 Refs: #25029 PR-URL: #25126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
sequential/test-inspector-debug-end and parallel/test-child-process-execfile Off late these have been failing in AIX. Debugging core dump suggested that this is a side effect of exit-race that is described in nodejs#25007 Mart these as flaky in AIX until that is resolved. Refs: nodejs#25047 Refs: nodejs#25029 PR-URL: nodejs#25126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 17, 2019
sequential/test-inspector-debug-end and parallel/test-child-process-execfile Off late these have been failing in AIX. Debugging core dump suggested that this is a side effect of exit-race that is described in #25007 Mart these as flaky in AIX until that is resolved. Refs: #25047 Refs: #25029 PR-URL: #25126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
sequential/test-inspector-debug-end and parallel/test-child-process-execfile Off late these have been failing in AIX. Debugging core dump suggested that this is a side effect of exit-race that is described in #25007 Mart these as flaky in AIX until that is resolved. Refs: #25047 Refs: #25029 PR-URL: #25126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
sequential/test-inspector-debug-end and parallel/test-child-process-execfile Off late these have been failing in AIX. Debugging core dump suggested that this is a side effect of exit-race that is described in #25007 Mart these as flaky in AIX until that is resolved. Refs: #25047 Refs: #25029 PR-URL: #25126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
sequential/test-inspector-debug-end and parallel/test-child-process-execfile Off late these have been failing in AIX. Debugging core dump suggested that this is a side effect of exit-race that is described in #25007 Mart these as flaky in AIX until that is resolved. Refs: #25047 Refs: #25029 PR-URL: #25126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
aix
Issues and PRs related to the AIX platform.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Off late this has been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart it as flaky in AIX until that is resolved.
Refs: #25047
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes