Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8: fix call of its own deprecated API #25148

Closed
wants to merge 1 commit into from
Closed

v8: fix call of its own deprecated API #25148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.7',
'v8_embedder_string': '-node.8',

##### V8 defaults for Node.js #####

Expand Down
14 changes: 2 additions & 12 deletions deps/v8/include/v8.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2631,8 +2631,7 @@ class V8_EXPORT String : public Name {
public:
virtual ~ExternalStringResourceBase() = default;

V8_DEPRECATE_SOON("Use IsCacheable().",
virtual bool IsCompressible() const) {
V8_DEPRECATED("Use IsCacheable().", virtual bool IsCompressible() const) {
return false;
}

Expand All @@ -2641,16 +2640,7 @@ class V8_EXPORT String : public Name {
* ExternalStringResource::data() may be cached, otherwise it is not
* expected to be stable beyond the current top-level task.
*/
virtual bool IsCacheable() const {
#if __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#endif
return !IsCompressible();
#if __clang__
#pragma clang diagnostic pop
#endif
}
virtual bool IsCacheable() const { return true; }

protected:
ExternalStringResourceBase() = default;
Expand Down