Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v10.15.0 proposal #25176

Merged
merged 10 commits into from
Dec 26, 2018
Merged

v10.15.0 proposal #25176

merged 10 commits into from
Dec 26, 2018

Commits on Dec 25, 2018

  1. test: remove magic numbers in test-gc-http-client-onerror 

    Remove magic numbers (500, 10, 100) from the test. Instead, detect when
GC has started and stop sending requests at that point.

On my laptop, this results in 16 or 20 requests per run instead of 500.

Fixes: #23089

PR-URL: #24943
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @Trott @MylesBorins
    Trott authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    3e14212 View commit details
    Browse the repository at this point in the history

  2. src: cache the result of GetOptions() in JS land 

    Instead of calling into C++ each time we need to check the value
of a command line option, cache the option map in a new
`internal/options` module for faster access to the values in JS land.

PR-URL: #24091
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @joyeecheung @MylesBorins
    joyeecheung authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    527407c View commit details
    Browse the repository at this point in the history

  3. test: fix expectation in test-bootstrap-modules 

    PR-URL: #25112
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    @ofrobots @MylesBorins
    ofrobots authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    728bc63 View commit details
    Browse the repository at this point in the history

  4. http: fix regression of binary upgrade response body 

    PR-URL: #25039
Fixes: #24958
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @mcollina @MylesBorins
    mcollina authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    1aea1e3 View commit details
    Browse the repository at this point in the history

  5. deps: cherry-pick http_parser_set_max_header_size 

    This commit adds http_parser_set_max_header_size() to the
http-parser for overriding the compile time maximum HTTP
header size.

Backport-PR-URL: #25168
PR-URL: #24811
Fixes: #24692
Refs: nodejs/http-parser#453
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @cjihrig @MylesBorins
    cjihrig authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    6183c71 View commit details
    Browse the repository at this point in the history

  6. src: add kUInteger parsing 

    This commit adds support for uint64_t option parsing.

Backport-PR-URL: #25168
PR-URL: #24811
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @mcollina @MylesBorins
    mcollina authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    a57aed1 View commit details
    Browse the repository at this point in the history

  7. cli: add --max-http-header-size flag 

    Allow the maximum size of HTTP headers to be overridden from
the command line.

Backport-PR-URL: #25168
co-authored-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #24811
Fixes: #24692
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @cjihrig @mcollina @MylesBorins
    2 people authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    9b2ffc8 View commit details
    Browse the repository at this point in the history

  8. doc: describe current HTTP header size limit 

    Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

PR-URL: #24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    @sam-github @MylesBorins
    sam-github authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    e669733 View commit details
    Browse the repository at this point in the history

  9. http: add maxHeaderSize property 

    This commit exposes the value of --max-http-header-size
as a property of the http module.

PR-URL: #24860
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig @MylesBorins
    cjihrig authored and MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    b6d3afb View commit details
    Browse the repository at this point in the history

  10. 2018-12-26, Version 10.15.0 'Dubnium' (LTS) 

    The 10.14.0 security release introduced some unexpected breakages on
the 10.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.

Notable Changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25176
    @MylesBorins
    MylesBorins committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    1ae0511 View commit details
    Browse the repository at this point in the history