Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: move process.features initialization into node.js #25239

Closed
wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Use internalBinding('config') to shim the legacy
process.features.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 27, 2018
Use `internalBinding('config')` to shim the legacy
`process.features`.
debug: isDebugBuild,
uv: true,
ipv6: true, // TODO(bnoordhuis) ping libuv
tls_alpn: hasOpenSSL,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be available as process.versions.openssl even though that's not the purpose of that property - I wonder if we should just use that instead?

@joyeecheung
Copy link
Member Author

@addaleax
Copy link
Member

addaleax commented Dec 27, 2018

@addaleax addaleax added process Issues and PRs related to the process subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 27, 2018
@addaleax
Copy link
Member

Landed in 39a2ac4

@addaleax addaleax closed this Dec 31, 2018
addaleax pushed a commit that referenced this pull request Dec 31, 2018
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: #25239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@addaleax
Copy link
Member

addaleax commented Jan 5, 2019

Should this be backported to v11.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: nodejs#25239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@addaleax
Copy link
Member

This applies cleanly now :)

addaleax pushed a commit that referenced this pull request Jan 15, 2019
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: #25239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: nodejs#25239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: nodejs#25239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants