Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: refactor AssertionError properties #25250

Closed
wants to merge 5 commits into from

Commits on Dec 28, 2018

  1. assert: make actual and expected getters

    The `actual` and `expected` properties on an instance of
    `AssertionError` is now a getter to prevent inspecting these when
    inspecting the error. These values will be visible in the error
    message and showing them otherwise would decrease the readability
    of the error.
    BridgeAR committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    ca7ad03 View commit details
    Browse the repository at this point in the history
  2. test: fix failing assertion

    One test did not cause an assertion. By changing the test to use
    `assert.throws()` all tests have to throw, otherwise the test will
    fail.
    BridgeAR committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    d92a714 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bc2ccc2 View commit details
    Browse the repository at this point in the history
  4. fixup: move comment

    BridgeAR committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    06e5388 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2019

  1. fixup: fix typo

    Co-Authored-By: BridgeAR <ruben@bridgewater.de>
    addaleax and BridgeAR authored Jan 9, 2019
    Configuration menu
    Copy the full SHA
    0f7ff0e View commit details
    Browse the repository at this point in the history