benchmark: fix net-wrap-js-stream-passthrough #25273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by 00944c7. This fixes it.
nodejs-github-bot
added
benchmark
lpinca
approved these changes
Dec 29, 2018
cjihrig
approved these changes
Dec 29, 2018
|
Benchmark tests aren't run in CI so Lite CI seems sufficient (as it will lint the change at least). |
|
Landed in 903630e |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 29, 2018
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by 00944c7. This fixes it. PR-URL: nodejs#25273 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by 00944c7. This fixes it. PR-URL: nodejs#25273 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Merged
Merged
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.
👍 here to fast-track. This fixes node-daily-master Jenkins job. (The benchmark tests are only run there.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes