-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working on 1.0.0 #253
Working on 1.0.0 #253
Conversation
🎉 |
8286eff
to
b31c073
Compare
👏👏👏 |
LGTM :-) |
⭐ |
PR-URL: #253 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Thanks Rod! Landed in 8a0e7d6 |
So |
I was thinking that we should add a |
I'm not saying I would be using it (though presumably |
I am in favor of adding |
\o/ |
@isaacs is that a +1 for an |
@rvagg Just general excitement about 1.0.0. Adding When do you need to feature-detect apart from the version number? Does anyone actually think that there will be a release of |
OT: @isaacs dropping the bomb? sounds almost like you don't believe in the work you do on the NAB? ;) |
|
btw, in |
and i think this should seem to be applied in |
My only concern is how |
@algesten I do believe that the JNAB is doing good work, and will get to a good place. But the place it'll get to is merging io.js into node, not creating a competing 1.0.0 release. The post-io.js node will likely be 1.next or 2.0.0. The version alone will thus be sufficient to differentiate. |
@isaacs I think As a result, I put together PR #491. As I'm sure you know, I share your desire to see Node and io.js converge again ere long, but until then, having a simple way to tell them apart from inside the runtime is useful. |
Someone has to do it!