win, url: make fileURLToPath return backslashes #25324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes fileURLToPath use backslashes as path separator on Windows Fixes: nodejs#25265
jasnell
approved these changes
Jan 3, 2019
lpinca
approved these changes
Jan 3, 2019
|
Failures are related. |
guybedford
approved these changes
Jan 4, 2019
| @@ -30,6 +30,17 @@ fs.readFile(url, common.mustCall((err, data) => { | |||
| // Check that using a non file:// URL reports an error | |||
| const httpUrl = new URL('http://example.org'); | |||
|
|
|||
| // Check that the fileURLToPath uses platform separator | |||
| ['file:///c:/tmp', 'file://tmp/tmp'].forEach((i) => { | |||
There was a problem hiding this comment.
The problem seems to be the file://tmp/tmp entry here being treated as invalid. Perhaps just make it file:///tmp/tmp?
3 tasks
|
Closing, #25349 has better tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
fileURLToPathuse backslashes as path separator on WindowsFixes: #25265
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes