-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: check for --prof in ParseArgs #2533
Conversation
Previously, all of the cli arguments are parsed and then we loop through the v8 arguments again. This patch removes the need for the additional loop as we can check if the argument is --prof during the initial ParseArgs.
I guess I don't really see the point. The number of comparisons stays the same, right? |
The number of comparisons doesn't change, but it prevents the additional loop through v8_argv. I trust your opinion though, so if you think it is worthless, I can close :] |
I suspect it's basically a wash and possibly a pico-deoptimization. The loop counter probably lives in a register but |
works for me |
Previously, all of the cli arguments are parsed and then we loop
through the v8 arguments again. This patch removes the need for the
additional loop as we can check if the argument is --prof during the
initial ParseArgs.