[v11.x] process: provide dummy stdio for non-console Windows apps

[addaleax]

Clean cherry-pick of #20640, it’s just macOS CI that this may or may not end up being blocked on.

---

The only known condition where we could not provide appropriate
stdio streams so far were non-console Windows applications.
Since this issue has come up a few times in our issue tracker now,
switch to providing dummy streams for these cases instead.

If there are other valid cases in which uv_guess_handle fails,
and where there is a more sensible way to provide stdio,
we’ll probably still find out because the streams don’t work
properly either way.

[nodejs-github-bot]

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2145/pipeline

[addaleax]

CI: https://ci.nodejs.org/job/node-test-pull-request/19945/

[addaleax]

/cc @nodejs/platform-macos for investigating the failure

[bzoz]

For Windows, the compilation issue is strange:

23:05:08   Traceback (most recent call last):
23:05:08     File "..\src\inspector\build\xxd.py", line 28, in <module>
23:05:08       sys.exit(main())
23:05:08     File "..\src\inspector\build\xxd.py", line 24, in main
23:05:08       with open(output_filename, 'w') as output_file:
23:05:08   IOError: [Errno 13] Permission denied: 'c:\\workspace\\node-compile-windows\\Release\\obj\\global_intermediate\\src\\inspector\\injected-script-source.h'
23:05:08 C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [c:\workspace\node-compile-windows\deps\v8\gypfiles\v8_base_0.vcxproj]

Maybe just a fluke needing a retry?

/cc @nodejs/build @nodejs/platform-windows

[addaleax]

@bzoz Yeah, I wouldn’t worry about that for now… marking this as WIP while it’s failing on macOS

[Trott]

@addaleax Can reproduce failure locally on macOS. Going to bisect master to see if I can identify the commit that fixed it there.

[Trott]

It appears that 3337836 is the commit that fixed things so that this change no longer caused test failures on macOS. So maybe if that backport is done and landed first, this one will pass on macOS?

[BridgeAR]

@Trott thanks for investigating! I am going to land the mentioned backport later, so let's see if we are able to land this afterwards.

[BridgeAR]

LG if the CI is green.

[BridgeAR]

Landed in 8d166c9 🎉 (OS-X is finally green due to the console commit).

[addaleax]

@Trott @BridgeAR I’m not sure – this does not sound like the actual underlying issue that caused the crashs has been taken care of. It’s nice that CI is green though, and I don’t think many people would be running into problems (esp. on OS X, as this primarily targets Windows).