-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix test-repl timeout and tmpdir refresh #25425
Conversation
The pi1 devices have their own separate stress test Jenkins jobs. https://ci.nodejs.org/view/All/job/node-stress-single-test-pi1-binary/ and https://ci.nodejs.org/view/All/job/node-stress-single-test-pi1-fanned/ |
Ok, those do not seem to be listed under any existing tabs except "All". Could we add them (at least the fanned job) to the "Node.js" tab alongside the main stress test job that already exists there? |
@nodejs/build ^^^^^^^ |
Also it looks like the pi1-fanned job actually executes on pi2 and pi3 machines in addition to pi1. |
Does this make sense: https://ci.nodejs.org/view/Stress/ |
That is helpful, yes. Thanks. |
Landed in 7b6e9ae 🎉 |
PR-URL: #25425 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
PR-URL: #25425 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
PR-URL: #25425 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
PR-URL: #25425 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
I could not find a way to stress test this on the pi1 as armv6 (and armv7 for that matter) seems to not be a selectable target in Jenkins, although armv8/arm64 targets are?
Anyway, what prompted this was this recent CI failure on pi1-docker:
The tmpdir addition was to allow running the test by itself, outside of a
make test
.CI: https://ci.nodejs.org/job/node-test-pull-request/20036/
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes