Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector, test: verify reported console message #25455

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions test/parallel/test-inspector-console-top-frame.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
'use strict';

// Verify that the line containing console.log is reported as a top stack frame
// of the consoleAPICalled notification.
// Changing this will break many Inspector protocol clients, including
// debuggers that use that value for navigating from console messages to code.

const common = require('../common');
BridgeAR marked this conversation as resolved.
Show resolved Hide resolved
common.skipIfInspectorDisabled();

const assert = require('assert');
const { Session } = require('inspector');
const { basename } = require('path');

function logMessage() {
console.log('Log a message');
}

const session = new Session();
let topFrame;
session.once('Runtime.consoleAPICalled', (notification) => {
topFrame = (notification.params.stackTrace.callFrames[0]);
});
session.connect();
session.post('Runtime.enable');

logMessage(); // Triggers Inspector notification

session.disconnect();
assert.strictEqual(basename(topFrame.url), basename(__filename));
assert.strictEqual(topFrame.lineNumber, 15);