Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor two http client timeout tests #25473

Closed
wants to merge 1 commit into from
Closed

test: refactor two http client timeout tests #25473

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jan 13, 2019 •
edited
Loading

Refactor test-http-client-set-timeout and test-http-client-timeout-option-with-agent.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@lpinca sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 13, 2019
@lpinca lpinca added the http Issues or PRs related to the http subsystem. label Jan 13, 2019
@lpinca
Copy link
Member Author

lpinca commented Jan 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20083/

@lpinca lpinca force-pushed the remove/unneeded-timers branch from 6db4080 to d10b021 Compare January 15, 2019 09:57
@lpinca
Copy link
Member Author

lpinca commented Jan 15, 2019

New CI: https://ci.nodejs.org/job/node-test-pull-request/20136/

This was referenced Jan 16, 2019
Closed
Closed
Closed
@lpinca lpinca force-pushed the remove/unneeded-timers branch from d10b021 to f27b501 Compare February 6, 2019 11:52
@lpinca
test: refactor two http client timeout tests
95e6baa 
Refactor test-http-client-set-timeout and
test-http-client-timeout-option-with-agent.
@lpinca lpinca force-pushed the remove/unneeded-timers branch from f27b501 to 95e6baa Compare February 7, 2019 07:56
@lpinca lpinca changed the title test: remove two unneeded timers test: refactor two http client timeout tests Feb 7, 2019
@lpinca
Copy link
Member Author

lpinca commented Feb 7, 2019

New CI: https://ci.nodejs.org/job/node-test-pull-request/20636/
cc: @nodejs/testing

@Trott
Copy link
Member

Trott commented Feb 9, 2019

Resume Build CI; https://ci.nodejs.org/job/node-test-pull-request/20679/

@Trott
Copy link
Member

Trott commented Feb 9, 2019

@nodejs/http

@lpinca
Copy link
Member Author

lpinca commented Feb 12, 2019

Landed in b361f95.

@lpinca lpinca closed this Feb 12, 2019
@lpinca lpinca deleted the remove/unneeded-timers branch February 12, 2019 07:02
lpinca added a commit that referenced this pull request Feb 12, 2019
@lpinca
test: refactor two http client timeout tests
b361f95 
Refactor test-http-client-set-timeout and
test-http-client-timeout-option-with-agent.

PR-URL: #25473
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 13, 2019
@lpinca @addaleax
test: refactor two http client timeout tests
6323a9f 
Refactor test-http-client-set-timeout and
test-http-client-timeout-option-with-agent.

PR-URL: #25473
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpinca @nodejs-github-bot @Trott @jasnell