doc: fix http.Agent timeout option description #25489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the agent options are passed to `net.createConnection()` which sets the timeout on the socket immediately after creating it.
|
@lpinca sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
doc
addaleax
approved these changes
Jan 28, 2019
|
Landed in 9dc1176 |
pull bot
pushed a commit
to Rachelmorrell/node
that referenced
this pull request
Jan 28, 2019
By default the agent options are passed to `net.createConnection()` which sets the timeout on the socket immediately after creating it. PR-URL: nodejs#25489 Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Jan 28, 2019
By default the agent options are passed to `net.createConnection()` which sets the timeout on the socket immediately after creating it. PR-URL: #25489 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 29, 2019
By default the agent options are passed to `net.createConnection()` which sets the timeout on the socket immediately after creating it. PR-URL: #25489 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
By default the agent options are passed to `net.createConnection()` which sets the timeout on the socket immediately after creating it. PR-URL: #25489 Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
By default the agent options are passed to `net.createConnection()` which sets the timeout on the socket immediately after creating it. PR-URL: #25489 Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced May 29, 2019
This was referenced Aug 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the agent options are passed to
net.createConnection()which sets the timeout on the socket immediately after creating it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes