Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crypto::Hash update method's error output #25533

Closed
wants to merge 1 commit into from

Conversation

amitzur
Copy link
Contributor

@amitzur amitzur commented Jan 16, 2019

Fixes: #25487

This PR adds Buffer to the list of possible input types for Hash.update in the error for invalid input type. One test was added for verifying the error output is as expected.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the crypto Issues and PRs related to the crypto subsystem. label Jan 16, 2019
@danbev
Copy link
Contributor

danbev commented Jan 21, 2019

@thefourtheye
Copy link
Contributor

I understand that this just includes a word in the error message (the functionality is already working as expected), should this be treated as a major change?

@addaleax
Copy link
Member

addaleax commented Feb 9, 2019

@thefourtheye I wouldn’t say so – we have an error code, so that should be okay.

Landed in e0a3d74, and thanks for the PR! 🎉

@addaleax addaleax closed this Feb 9, 2019
@addaleax addaleax reopened this Feb 9, 2019
addaleax pushed a commit that referenced this pull request Feb 9, 2019
Fixes: #25487

PR-URL: #25533
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Feb 10, 2019
Fixes: #25487

PR-URL: #25533
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@thefourtheye
Copy link
Contributor

As the patch landed, this PR can be closed now. Thanks @amitzur for the PR 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants