Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove erroneous duplicate declaration from node_inspector.gypi #25586

Closed
wants to merge 0 commits into from
Closed

build: remove erroneous duplicate declaration from node_inspector.gypi #25586

wants to merge 0 commits into from

Conversation

refack
Copy link
Contributor

@refack refack commented Jan 19, 2019 •
edited
Loading

@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2303/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 19, 2019
@refack refack self-assigned this Jan 19, 2019
@refack refack added inspector Issues and PRs related to the V8 inspector protocol build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files and removed c++ Issues and PRs that require attention from people who are familiar with C++. labels Jan 19, 2019
@refack refack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 19, 2019
@refack refack force-pushed the inspector_gypi_oops branch from 85cd14b to 5b6a4e6 Compare January 22, 2019 17:09
@refack
Copy link
Contributor Author

refack commented Jan 22, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20262/

refack added a commit that referenced this pull request Jan 22, 2019
@refack
build: remove erroneous duplicate declaration from node_inspector.gypi
5d80f9e 
PR-URL: #25586
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@refack refack closed this Jan 22, 2019
@refack refack force-pushed the inspector_gypi_oops branch from 5b6a4e6 to 5d80f9e Compare January 22, 2019 21:21
@refack refack deleted the inspector_gypi_oops branch January 22, 2019 21:21
@refack refack added the landed label Jan 22, 2019
@refack
Copy link
Contributor Author

refack commented Jan 22, 2019

landed in 5d80f9e

addaleax pushed a commit that referenced this pull request Jan 23, 2019
@refack @addaleax
build: remove erroneous duplicate declaration from node_inspector.gypi
8cc936a 
PR-URL: #25586
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
@refack refack removed their assignment Mar 11, 2019
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@refack @BethGriggs
build: remove erroneous duplicate declaration from node_inspector.gypi
b8aca29 
PR-URL: #25586
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@refack @BethGriggs
build: remove erroneous duplicate declaration from node_inspector.gypi
ba1660d 
PR-URL: #25586
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@refack @MylesBorins
build: remove erroneous duplicate declaration from node_inspector.gypi
a575a41 
PR-URL: #25586
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request May 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@refack @nodejs-github-bot @addaleax @cjihrig